Re: [patch] Boost.Signals + diatribe (Re: [signals] Re: [boost] t ake-2 [patch] usage of asserts with pointers in boost)

From: Lars Gullik Bjønnes (larsbj_at_[hidden])
Date: 2002-08-07 10:36:29

"David Abrahams" <dave_at_[hidden]> writes:

| From: "Lars Gullik Bjønnes" <larsbj_at_[hidden]>
>
>> It is pretty obvious that my notion of common sense it not the same as
>> yours.
>>
>> To me it should be enought to put [patch] in the subject to at least
>> get people to look at it and comment.
>
| Do you expect everyone who's ever developed a boost library to look?

obviously not...

| There
| is only one person qualified to comment on the patch you posted.

OK... did you look at this patch at all?

char * p = 0;
assert(p);

gives a warning on (some) 64bit platforms

assert(p != 0); 

does not.

If only one person is qualified to comment on this...

| What if he
| doesn't happen to be among the lookers?

Then perhaps someone should chime up and say that this person _must_
look at this patch.

>> For a cross lib patch, should I then put every lib touched on the
>> subject line?
>
| If there are only a few libs involved, separate postings per lib is better.
| If there are lots of libs involved, a note like "Whole library patch:" in
| the subject would be helpful.
| Hopefully, the latter will be rare.

Perhaps some formal patch posting guidelines should be written down.
And a maintainers file.

-- 
	Lgb