Re: [boost] numeric_limits<uint64_t> bug in boost/limits.h

From: Stephen Nutt (snutt_at_[hidden])
Date: 2002-09-08 11:52:58

Thank you John

----- Original Message -----
From: "John Maddock" <jm_at_[hidden]>
To: <boost_at_[hidden]>
Sent: Sunday, September 08, 2002 6:47 AM
Subject: Re: [boost] numeric_limits<uint64_t> bug in boost/limits.h

> > The defintion of digits and digits10 is incorrect for the unsigned long
> > long.  Currently they are
> >       BOOST_STATIC_CONSTANT(int, digits = sizeof(BOOST_LLT) *
> CHAR_BIT -1);
> >       BOOST_STATIC_CONSTANT(int, digits10 = (CHAR_BIT * sizeof
> (BOOST_LLT) -
> > 1) * 301L / 1000);
> > but should be
> >       BOOST_STATIC_CONSTANT(int, digits = sizeof(BOOST_LLT) * CHAR_BIT);
> >       BOOST_STATIC_CONSTANT(int, digits10 = (CHAR_BIT * sizeof
> (BOOST_LLT))
> > * 301L / 1000);
>
> Well spotted, thanks.
>
> > Also, I did not get these definitions without having to first define
> > BOOST_NO_MS_INT64_NUMERIC_LIMITS.  Should this not be defined in
> > config/compiler/visualc.hpp?
>
> It's set in dinkumware.hpp for VC6, but not it seems for VC7 - should be
> fixed now.
>
> John Maddock
> http://ourworld.compuserve.com/homepages/john_maddock/index.htm
>
>
> _______________________________________________
> Unsubscribe & other changes:
http://lists.boost.org/mailman/listinfo.cgi/boost
>