[boost] Re: [dynamic bitset] Wrong test for MSVC6/7 and dinkumwarelib?

From: Markus Schöpflin (markus.schoepflin_at_[hidden])
Date: 2002-10-01 04:54:49

Björn Karlsson wrote:
> 
> > From: Markus Schöpflin [mailto:markus.schoepflin_at_[hidden]]
> > It's even more complicated than that. :-)
> >
> > You can't check for Dinkumware lib with MSVC6 because it
> > doesn't define
> > _CPPLIB_VER. This macro is only defined in later version of
> > the Dinkumware
> > library. I think that's why there was a test for
> > !defined(_CPPLIB_VER).
> 
> Aha! That makes sense. Then I suggest we do this:
> #if (defined(_MSC_VER) && (_MSC_VER <= 1300)) && ((!defined(_CPP_LIB_VER) &&
> defined(_YVALS)) || (defined(_CPPLIB_VER) && (_CPPLIB_VER < 306)))
> 
> as _YVALS is defined on MSVC 6.

I think this still fails for MSVC6 with STLport because _YVALS will be
defined anyway. (STLport does include some headers of the original STL.)
This is why the config system checks for the presence of STLport _before_
any other library.

> 
> > The config system already does all the hard work for us, why
> > don't why add
> > some makro to it?
> 
> Sounds like a good idea, but adding a config macro is a "global operation",
> while changing this faulty test is a very localized change. For now, I think
> we should concentrate on getting this right, preferably before 1_29_0 is
> released.

Violent agreement!

Markus