Re: [boost] Formal Review: The Spirit Parser Framework.

From: Larry Evans (jcampbell3_at_[hidden])
Date: 2002-10-12 17:10:22

John Maddock wrote:

>The formal review for the Spirit Parser Framework begins today, and runs
>until the end of Sunday 20th October.
>
>Discussion should take place on the main boost developer list
>(boost_at_[hidden]), please state in your review whether you think the
>framework should be accepted into boost or not.
>
>  
>
Spirit should be accepted.

I'd suggest a change in the rule.html file.  This file contains the 
statement:

    Cyclic references will result in memory leaks.

which is followed by an example with no cycles.  However, I think
even with cycles, there should be some explanation of why weak_ptr<rule>
couldn't occur on the rhs and avoid the cycle problem.