Re: [boost] Re: Formal Review: The Spirit Parser Framework.

From: Beman Dawes (bdawes_at_[hidden])
Date: 2002-10-12 16:43:44

At 12:10 PM 10/12/2002, Joel de Guzman wrote:
 >
 >
 >Here, expect(')') throws an exception when a close paranthesis
 >is not found. This exception is caught by expr_guard and is
 >handled by handle_invalid_espression.
 >
 >... I still assert that we should not force libraries to follow a
 >canonical form. We can never be sure if such rules will apply
 >to *all* libraries. In the case of Spirit, I don't see how
 >deriving from the std exceptions will benefit the library
 >or the library users. In fact, it will just add a virtual table and
 >possibly a char const* or a std::string to the parser exception
 >which will be wasted and unused.

Agreed.  That's why I added the "...unless there is some application 
specific reason..." caveat:

 >>  >I'd like to suggest (to the Boost readership in general) that this
 >>  >should be made a requirement for all Boost libraries.
 >>
 >> I agree, unless there is some application specific reason why another
 >> approach is better.

When usual coding conventions aren't followed, it helps to add a rationale 
as to the reason.  That eliminates needless queries.

Anyhow, I'm looking forward to reading more about Spirit.

--Beman