Re: [boost] Formal Review: The Spirit Parser Framework.

From: Joel de Guzman (djowel_at_[hidden])
Date: 2002-10-15 00:05:44

----- Original Message ----- 
From: "Larry Evans" <jcampbell3_at_[hidden]>

> A few for Spirit html suggestions:
> ----------------------------------
> preface.html:
> 
>     In many cases, though, it is unavoidable that advanced but
>     related topics not be interspersed with the normal flow of
> -> related topics are interspersed with the normal flow of
>     discussion.

Done.

> quick_start.html:
> 
>     Under _Trivial Example #1_:
> 
>       real_p
> 
>       The above code actually generates a Spirit real_parser
> 
> ->   The global variable, real_p, is an instance of real_parser,
>       which parses a floating point number.

Ok. Done.

> basic_concepts.html:
> 
>     The 1st parse tree after in the _Primitives and Composites_
>     section does not accurately reflect the grammar:
> 
>           real_p >> *(',' >> real_p)
> 
>     It should be something like:
> 
>                         sequence
>                         /      \
>                    real_p   longest_alternative
>                              /      \        /|\
>                          eps_p   sequence     |
>                                  /    |       |
>                            ch_p(',')  |       |
>                                       |       |
>                                       |       |
>                                  sequence     |
>                                  /      \_____|
>                            real_p

Actually, this was spotted but slipped the v1.5.1 release. The actual 
parse tree should be:

        sequence
        /      \
     real_p   kleene_star
                    |
                sequence
                /      \
         ch_p(',')    real_p
         

Many thanks!
--Joel