Boost logo

Boost :

From: depdev.sdi_at_[hidden]
Date: 2002-10-22 06:22:00

Hi, I know the review period is over but I only have one remark to add to the subject.

First of all, I think it is a superb library, so many thanks for the author for leting me use

I started a litle toy project of a c preprocessor analyser (for checking what macros are
being used/tested), but as my parser knowledge is a litle rusty and my free time is
scarse, I'm taking it slowly.

The only comment I have of relevance is the use of range_p( ch_first, ch_last ).
As the type char is signed, a range like [ '\xC0', '\xC4' ] throws an assertion error
(ch_last less than ch_first). Another example is range_p( '\x21', '\xFF' ), for all non
control chars (in 8-bit latin1).

I understand that this can be a litle controverse as the type is signed (for the majority of
the compilers), but I think it is more natural if the range could be unsigned (at least for
foreign users like me that use more than 7-bit chars).


   ~Nuno Lucas

SDI - Sistemas e Desenvolvimento Informático
Rua Nova da Estação, 315 -- 4710-234 Braga
Tel: 253 268 690/1 Fax: 253 268 692

Boost list run by bdawes at, gregod at, cpdaniel at, john at