Boost logo

Boost :

From: Thomas Witt (witt_at_[hidden])
Date: 2002-11-03 11:38:47

Formal Review Results

Minmax has been accepted into boost.
Congratulations Herve.

During the review a number of issues were raised that should be aressed in
order to improve the library. I will again list the most important ones.


The current implementation contains a lot of duplicated code. A policiy based
approached as proposed by Gennadiy should be seriously considered.

-- Interface

A policiy based interface for the last/first functions _might_ be better. For
now I think that this issue is not important enough to reject the library.
The interface can still be revised when user experience shows that this is

General sequence_algo issues

The following issue relates not only to minmax but to all sequence algorithms.

Given the pain one has to go through when renaming files/directories in CVS, I
would like to ask the question whether the directory should really be
sequence_algo. I cannot recall how this name was intially created, but the
small benefit created by abbreviating algorithm (13/18 letters) makes me feel
unsure about the name.


Minmax Review Manager

Dipl.-Ing. Thomas Witt
Institut fuer Verkehrswesen, Eisenbahnbau und -betrieb, Universitaet Hannover
voice: +49(0) 511 762 - 4273, fax: +49(0) 511 762-3001

Boost list run by bdawes at, gregod at, cpdaniel at, john at