Re: [boost] Re: BOOST_CHECK_EQUAL() dangers

From: David Abrahams (dave_at_[hidden])
Date: 2002-11-20 17:03:52

"Gennadiy Rozental" <gennadiy.rozental_at_[hidden]> writes:

>> 1. Just document it. Not so good, IMHO.
>>
>> 2. Document the special case and add a check for NULL pointers before
>> calling strcmp().
>>
>> 3. Remove the special case alltogether. After all, I might want to check
>> that the pointers are equal and not the string they point to. This might
>> be the best solution, but breaks backward compatibility.
>>
>> Markus
>
> In majority of the cases when user is comparing two character pointers he
> need namely "string comparison". Requiring to cast both sides to std::string
> is a big burden IMO. 

Really?

        BOOST_CHECK_EQUAL(std::string(x), std::string(y))

> So I would choose  solution 2.

:(

-- 
                       David Abrahams
   dave_at_[hidden] * http://www.boost-consulting.com
Boost support, enhancements, training, and commercial distribution