Re: [boost] VC7/Threads Warnings

From: William E. Kempf (wekempf_at_[hidden])
Date: 2003-03-25 18:10:39

David Abrahams said:
> "William E. Kempf" <wekempf_at_[hidden]> writes:
>
>> David Abrahams said:
>>> "William E. Kempf" <wekempf_at_[hidden]> writes:
>>>
>>>> Hmm... this surprised me.  Mr. Maclean indicated the warnings were
>>>> level 1 _and_ 2.  Builds with bjam do report errors, so the warning
>>>> level can't be 0.  MSDN indicates "Level 2 is the default warning
>>>> level at the command line."  So I assumed that it must be an RTL
>>>> issue causing the warnings for him.  However, experimenting with
>>>> 'bjam -sTOOLS=vc7
>>>> -sBUILD="<vc7><*><cxxflags>-W2' does indeed produce the warnings in
>>>> question.  So it appears that MSDN is wrong, and that level 1 is
>>>> selected if none is supplied?  I plan to bump the level up in my own
>>>> set of bjam tool sets.
>>>
>>> Suggestion: turn them on with #pragmas in the library's test files.
>>
>> This won't turn them on when compiling the library itself, though.
>> Turning them on only for the test files won't catch many of the
>> warnings.
>
> So I suggest you use #pragmas in the library implementation files
> also.  My point is that you shouldn't need a custom toolset to see the
> warnings, and if it's your aim to avoid triggering them they
> should show up in the Boost regression tests when you do.

I guess I'm wondering if the official toolsets shouldn't be changed.  I
don't understand why the MSDN indicates it should default to /W2 while
we're seeing it default to what I assume is /W1.  But, projects created by
the IDE default to /W3 (which is also the level recommended by the MSDN),
so it makes sense to me that we should probably do the same?  Otherwise,
users are likely to see warnings that we don't represent in the regression
logs.

-- 
William E. Kempf