[boost] Re: tokenizer comments

From: Daryle Walker (dwalker07_at_[hidden])
Date: 2003-06-28 03:18:43

On Friday, June 27, 2003, at 8:59 AM, Edward Diener wrote:

> Bjorn.Karlsson_at_[hidden] wrote:
>>> From: Edward Diener [mailto:eddielee_at_[hidden]]
[SNIP]
>>> "The Tokenizer documentation for char_separator tokenizer
>>> function states that the default argument for the second template 
>>> type is "char_traits<char>". This is incorrect. The source code in 
>>> token_functions.hpp clearly shows that the default argument is 
>>> "std::basic_string<Char>::traits_type". Could this please be 
>>> corrected ?"
>>
>> I don't think that the documentation should change (not counting the 
>> change from char to Char), but rather the implementation.
>> std::basic_string<Char>::traits_type will always be
>> std::char_traits<Char>. If there are no objections to this (there
>> might have been some compiler issue that justified the code, although 
>> there's no such indication in the CVS history), I'll change 
>> token_functions.hpp accordingly.
>
> You will probably want to change escaped_list_separator in the same 
> way.

Since

        std::basic_string<Ch>::traits_type == std::char_traits<Ch>

is always true, shouldn't both the code and documentation be changed?  
There is no need to hide the class's identity.

Daryle