Re: [boost] [PATCH] libs/integer/cstdint_test.cpp should define __STDC_CONSTANT_MACROSearlier

From: Beman Dawes (bdawes_at_[hidden])
Date: 2003-08-16 14:17:21

At 02:10 PM 8/15/2003, Douglas Paul Gregor wrote:
 >The test case libs/integer/cstdint_test.cpp includes <cassert> and
 ><iostream> _before_ it defines __STDC_CONSTANT_MACROS. This means that on
 >a platform that (a) supports defining the C99 macros in <stdint.h> when
 >__STDC_CONSTANT_MACROS is defined and (b) uses <stdint.h> somewhere in
 ><iostream>, the test fails, because __STDC_CONSTANT_MACROS has been
 >defined too late for <stdint.h> header to react (because it presumably 
has
 >include guards).
 >
 >I believe the test case is wrong, and we should apply the patch below. 
Ok?

Doug,

I'm not sure there is anyone at the helm of cstdint_test.cpp to answer you. 
John Maddock, maybe.

So it seems to me you should go ahead and apply the patch. Just keep an eye 
on regression results for several platforms to make sure it doesn't break 
anything.

My two cents,

--Beman