Re: [boost] date_time: ISO week number error and Calendar FAQ references

From: Jeff Garland (jeff_at_[hidden])
Date: 2003-09-25 06:18:06

On 25 Sep 2003 12:23:58 +0200, Claus Tondering wrote
> The Boost date_time source code kindly refers to my Calendar FAQ
> document.
> 
> I have a few comments in this connection:
>
> 1) In boost/date_time/gregorian_calendar.ipp I would appreciate it if
>    you would spell my name correctly (it's Tondering, not Todering).

Done.

> 2) In the same file you use an algorithm for calculating the ISO week
>    number found in the April 2000 version of the Calendar FAQ. You
>    have, however, made an error when translating the algorithm from
>    English into C++:
>
>...detail omitted...
>

Fixed and new test added for this case.  

> 3) Incidentally, newer versions of the Calendar FAQ contain a better
>    algorithm for calculating the week number:
>
>...detail omitted...
>

Thx, I'll look into this.

> 4) In libs/date_time/doc/References.html you should use this URL for
>    the Calendar FAQ:
> 
>         http://www.tondering.dk/claus/calendar.html

Done.

Thanks very much for your detailed review, and for providing a great resource!

Jeff