[boost] Re: Re: Re: [rational] why is int_type private?

From: Jonathan Turkanis (technews_at_[hidden])
Date: 2004-03-02 03:50:05

<Bjorn.Karlsson_at_[hidden]> wrote in message
news:3D8559AE95B4D611B02C0002557C6C8BA4DB8D_at_STH-EXCH...
> > From: Jonathan Turkanis [mailto:technews_at_[hidden]]
> >
> > Okay, here's a patch for boost/rational.hpp. Please let me know if
> > it's not in a suitable format.
> >
> > Jonathan
>
> Thanks Jonathan,
> It would be even better with a patch for the documentation, too.
Making
> these two typedefs public warrants more than just changing private
to public
> in the code, in my opinion.
>

I'm having second thoughts about param_type being public. Currently
the documentation 'lies' by documenting all occurences of param_type
as occurences of int_type. Maybe this okay.

If so a minimalist solution would be to make int_type, but not
param_type, public. int_type already appears in the synopsis and is
self explanatory, so tidying up the docs -- by adding 'public:' and a
semicolon at the end of the synopsis -- can probably wait.

Jonathan