[boost] Re: Boost.Threads metacomm regression tests not working

From: Michael Glassford (glassfordm_at_[hidden])
Date: 2004-07-15 11:30:54

Jeff Garland wrote:

> On Thu, 15 Jul 2004 07:55:44 -0700, Jeff Garland wrote
> 
>>Mike -
>>
>>This is also failing on my mini-Linux test with the same issue.
>>
>>http://boost.sourceforge.net/regression-logs/cs-LinuxMandrake.html
>>
>>It's interesting that if I change to the libs/thread/build directory 
>>and type bjam the library builds, so it seems like maybe this is 
>>some new change in the bjam system causing this.  That said in 
>>date_time there is 
>>
>>      <sysinclude>$(BOOST_ROOT) 
>>
>>in the Jamfile to make sure the appropriate include path is 
>>available.  I've locally modified the thread Jamfile to include a 
>>this sysinclude and I'm re-running the regression now.  I'll let you 
>>know...
> 
> 
> replies to self....
> 
> Adding the sysinclude indeed fixes the initial compilation problem.  

Thanks for figuring this out!

I'm far from a bjam expert, but one thing I don't quite understand is 
that the "<sysinclude>$(BOOST_ROOT)" is already defined in the 
thread_base template, which both of the templates you modified include. 
Is the problem perhaps that they include it only in the sources section 
and not in the requirements section? In other words, should your patch 
be modified to read as below?

 > I've
> attached a patch of the change I made and I'll reupload the regression results
> -- there's more errors :-(

Hopefully I can deal with these once I can see them.

> ------------------------------------------------------------------------
> 
> Index: Jamfile
> ===================================================================
> RCS file: /cvsroot/boost/boost/libs/thread/build/Jamfile,v
> retrieving revision 1.28
> diff -u -r1.28 Jamfile
> --- Jamfile	25 Jun 2004 20:17:19 -0000	1.28
> +++ Jamfile	15 Jul 2004 15:16:19 -0000
> @@ -49,6 +49,7 @@
>            <template>thread_base
>            ../src/$(CPP_SOURCES).cpp
>          : ## requirements ##
   +          <template>thread_base
>            <define>BOOST_THREAD_BUILD_LIB=1
>            <runtime-link>static
>            # the common names rule ensures that the library will
> @@ -63,6 +64,7 @@
>            <template>thread_base 
>            ../src/$(CPP_SOURCES).cpp
>          : ## requirements ##
   +          <template>thread_base
>            <define>BOOST_THREAD_BUILD_DLL=1
>            <runtime-link>dynamic
>            # the common names rule ensures that the library will

Mike