[boost] Re: [program_options] Need help with remaining fails

From: David Abrahams (dave_at_[hidden])
Date: 2004-07-21 06:41:04

Vladimir Prus <ghost_at_[hidden]> writes:

> Hi Rene,
>
>> ### mwcc Compiler:
>> #      In: ..\boost\program_options\detail\utf8_codecvt_facet.hpp
>> #    From: ..\libs\program_options\test\unicode_test.cpp
>> # ------------------------------------------------------
>> #     155:  };
>> # Warning:   ^
>> # 
>>
> 'boost::program_options::detail::utf8_codecvt_facet_wchar_t::do_length(const
>> int &, const char *, const char *, unsigned int) const' hides inherited
>> virtual function 'std::codecvt<wchar_t, char, int>::do_length(int &,
>> const char *, const char *, unsigned int) const'
>> 
>> As it turns out, this is a valid warning. 
>
> Yes, you're right. I've fixed it. Actually, I start to wonder if Boost
> should have -Woverloaded-virtual added to gcc flags.
>
>> virtual int do_length(stateT&, const externT* from,
>> const externT* end, size_t max) const;
>> 
>> This doesn't fix the failure, 
>
> Yea, I don't think this function is ever called.

That's a problem in itself; regression tests should achieve coverage.

-- 
Dave Abrahams
Boost Consulting
http://www.boost-consulting.com