Re: [boost] Graph broken for vc7.1 after 1.31?

From: Doug Gregor (dgregor_at_[hidden])
Date: 2004-09-29 09:19:55

[Moving to the Boost list only]

On Sep 29, 2004, at 9:07 AM, Vladimir Prus wrote:

> Hi Doug,
>> Vladimir,
>>
>> You'd regenerated the bison/flex output after 1.31.0, which has caused
>> both this problem and the regression noted by Jeffrey Holle on the
>> users list yesterday. Perhaps we should revert this directory to its
>> 1.31.0 state.
>
> It's not so easy :-( I've regenerated the files as part of this commit:
>
> 2004-01-26 12:16  vladimir_prus
>
>         * graphviz_digraph_parser.cpp, graphviz_graph_parser.cpp,
>         graphviz_parser.yy: Fix (or rather workaround) the bug which 
> caused
>         second reading of graphviz file to fail. Looks like the parser 
> is
>         not reenterant.
>
>         Patch from anynymous user.
>
> so if we revert the files back, we'll introduce back a bug.

Argh!

>  I've just
> regenerated the files again and Jeffrey's problem is gone. Guess we'd 
> need to
> #define YY_NO_UNISTD_H
> to fix the other problem. I've added that to Jamfile and the files 
> seems to
> still build.
>
> Should I commit the regenerated files and Jamfile changes?

Sure. Were you able to check it on VC 7.1?

>> We'll deprecate it in 1.32.0 (when, hopefully, we will
>> have a new GraphViz parser that works well) and remove it afterwards.
>
> How the new parser will be implemented?

Spirit. Granted, they've dropped support for older, broken compilers, 
so someone will still be getting hurt by this.

        Doug