Re: program_options patch (Was: [boost] [1.32 Release] New tarballs are available for testing)

From: Vladimir Prus (ghost_at_[hidden])
Date: 2004-11-03 02:16:24

On Wednesday 03 November 2004 02:11, Aleksey Gurtovoy wrote:
> Matthias Troyer writes:
> > Could these patches be applied to make program_options compile with the
> > IBM compiler?
>
> Vladimir?

Applied to trunk and branch. Thanks, Matthias!

> > --- boost/boost/program_options/detail/utf8_codecvt_facet.hpp   Wed Jul
> > 21 09:49:15 2004
> > +++ ../utf8_codecvt_facet.hpp   Tue Nov  2 15:05:34 2004
> > @@ -146,7 +146,11 @@
> >           const char * from,
> >           const char * from_end,

Is it possible that in future, you send patches at attachments. Posting them 
inline can cause line wrapping (like below), and is less reliable. I could 
not apply your patch automatically (even after unwrapping).

> >           std::size_t max_limit
> > +#if BOOST_WORKAROUND(__IBMCPP__, BOOST_TESTED_AT(600))
> > +    ) const throw();
> > +#else
> >       ) const;
> > +#endif
> >
> >       // Largest possible value do_length(state,from,from_end,1) could
> > return.

Here's wrapped line.

- Volodya