Re: [boost] [serialization] problemwithboost/serialization/is_abstract.hpp

From: JOAQUIN LOPEZ MU?Z (joaquin_at_[hidden])
Date: 2004-11-04 14:33:57

----- Mensaje original -----
De: Aleksey Gurtovoy <agurtovoy_at_[hidden]>
Fecha: Jueves, Noviembre 4, 2004 7:58 pm
Asunto: Re: [boost] [serialization] 
problemwithboost/serialization/is_abstract.hpp

> Joaquín Mª López Muñoz writes:
> > In MSVC 6.0, the following snippet fails:
> >
> > #include <boost/archive/text_iarchive.hpp>
> > #include <boost/tuple/tuple.hpp>
> 
[...]
> > complaining about is_abstract being already defined. The problem
> > lies in the following lines inside 
> boost/serialization/is_abstract.hpp:>
> > #ifndef BOOST_TT_IS_ABSTRACT_CLASS_HPP
> > #if    defined(__GNUC__) && (34 <= _GNUC__ * 10 + __GNU_MINOR)  \
> >     || defined(__MSVC_VER) && (1310 <= __MSVC_VER)              \
> >     || defined(__EDG_VERSION__)                                 \
> >     /**/
> >     #include <boost/type_traits/is_abstract.hpp>
> > #else
> 
> First of all, the whole thing is a huge hack and can cause an ODR
> violation on 1-2-3. We should really fix type_traits to fall back to
> something like the code below, but that is definitely out for the
> release.

Yep, I'll take care of this as soon as Boost 1.32 is
out -I need it for my own purposes :)

> 
> Having said that, the #else branch is simply missing this:
> 
> #   define BOOST_TT_IS_ABSTRACT_CLASS_HPP
> 
[...]
 
> > If nobody complains, I can fix this and commit it to the release and
> > main branch.
> 
> Please! Together with the #define, if you can.

Consider it done in approx. 12 hours from now.

Joaquín M López Muñoz
Telefónica, Investigación y Desarrollo