Re: [boost] Boost 1.32.0 FreeBSD port ready -- please review patches

From: Simon Barner (barner_at_[hidden])
Date: 2005-01-06 20:20:34

John Maddock wrote:
> >http://www.freebsd.org/cgi/cvsweb.cgi/~checkout~/ports/devel/boost/files/patch-boost%3a%3aconfig%3a%3aplatform%3absd.hpp?rev=1.1
> >
> >This patch enables wchar support on FreeBSD 5 and disables it on older
> >versions.
> >
> >Unfortunately, I can't remember, why 
> >BOOST_NO_INCLASS_MEMBER_INITIALIZATION
> >was necessary, but it won't hurt, will it?
> 
> Probably not, but it still looks like a mistake: gcc-3.3 shouldn't have any 
> issues with this.
> 
> >--- boost/config/platform/bsd.hpp.orig Fri Feb 27 14:13:00 2004
> >+++ boost/config/platform/bsd.hpp Wed Dec 15 16:01:21 2004
> >@@ -39,9 +39,20 @@
> 
> Simplified to just:
> 
> #if !(defined(__FreeBSD__) && (__FreeBSD__ >= 5))
> # define BOOST_NO_CWCHAR
> 
> #endif
> 
> Tested on FreeBSD 5 via HP testdrive, and looks OK.

Yes, thanks -- this works on my FreeBSD 5 machine, too. 

When I have verified this on FreeBSD 4, this should be merged into
Boost's CVS IMO (unlike the PTHREAD_{CFLAGS,LIBS} patches, which are
specific to the ports collection and would prevent building Boost
directly from the tarball).

> >Depending on the FreeBSD version, different compiler and linker options
> >are needed. These option are provided by two environment variables
> >PTHREAD_CFLAGS and PTHREAD_LIBS, but I found no other way of getting the
> >right values into Boost's config files than patching that will
> >placeholder values and using sed(1) to replace those dummies with the
> >actual ones.
> 
> You can use $(NAME) to refer to an environment variable in bjam, so I 
> assume that this should be:

Ah, it's $(FOO), and I kept on trying ${FOO}. Now it works, thanks :-)

[ snip ]

Simon