|
Boost : |
From: Gennadiy Rozental (gennadiy.rozental_at_[hidden])
Date: 2005-02-26 15:22:24
"David Abrahams" <dave_at_[hidden]> wrote in message
news:uwtsv1i84.fsf_-__at_boost-consulting.com...
> "Gennadiy Rozental" <gennadiy.rozental_at_[hidden]> writes:
>
> > "Gennadiy Rozental" <gennadiy.rozental_at_[hidden]> wrote in message
> > news:cvpn38$2fi$1_at_sea.gmane.org...
> >> 1. Shouldn't this header use workaround from config/suffix.hpp instead
of
> >> BOOST_EXPLICIT_DEFAULT_TARGET?
>
> Sure.
>
> >> 2. Shouldn't this header be split by ..._cast?
>
> Sure.
Does above 'sure' means you are going to take care about it, or you want me
to do it?
> >> 3. Doesn't numeric_cast facility shouldn't be deprecated?
> ^^^^^^^ ^^^^^^^^^
> ?? Double negative??
>
> Its implementation should be replaced by one that uses the Boost
> Numeric Conversion Library.
I think just include boost/numeric/cast.hpp will work. And test program
should be depricated either.
BTW I noticed that this test (either original in libs/convertion/test or
copy in libs/numeric/convertion/test) could use use BOOST_TEST_THROW in
stead of handcrafted checks.
> > 4. Shouldn't polymorphic_downcast work for references?
>
> I have no opinion.
In a book you have this in excesises. And i do not see why not?
> --
> Dave Abrahams
Gennadiy
Boost list run by bdawes at acm.org, gregod at cs.rpi.edu, cpdaniel at pacbell.net, john at johnmaddock.co.uk