Re: [boost] Re: [review] hash functions

From: Peter Dimov (pdimov_at_[hidden])
Date: 2005-03-09 07:46:46

Daniel James wrote:
> Bronek Kozicki wrote:
>>> The library is fairly small and can be seen as an extension to
>>> boost.functional.
>>> Therefore the review is a fast-track review.
>> 
>> 
>> Documentation mentions two overloaded functions:
>>   std::size_t hash_value(std::string);
>>   std::size_t hash_value(std::wstring);
>> 
>> while hash.hpp actually delivers one template function:
>>   template <class E, class T, class A>
>>   std::size_t hash_value(std::basic_string<E, T, A> const& v);
>> 
>> I'd prefer documentation updated. Overall I consider this
>> functionality desired in Boost; I also like design (single template
>> class hash calling overloaded hash_function).
> 
> Oh dear, it's actually the header file that's out of date. I changed
> it because it won't work for custom character traits.

Why do you think so?