[boost] range\config.hpp and regression tests broken

From: Victor A. Wagner Jr. (vawjr_at_[hidden])
Date: 2005-04-08 14:28:41

I arbitrarily rolled back (effectively) the 1.6 version of 
boost\range\config.hpp (see attached)

C:\Projects\boost\boost\range>cvs diff config.hpp
Index: config.hpp
===================================================================
RCS file: /cvsroot/boost/boost/boost/range/config.hpp,v
retrieving revision 1.6
diff -r1.6 config.hpp
36c36,37
< #if BOOST_WORKAROUND( BOOST_MSVC, <= 1200 ) || __MWERKS__ <= 0x3003
---
 > //#if BOOST_WORKAROUND( BOOST_MSVC, <= 1200 ) || __MWERKS__ <= 0x3003
 > #if _MSC_VER <= 1200 && !defined( __COMO__ ) && !defined( __GNUC__ ) && 
__MWERKS__ <= 0x3003
Note that I commented out the "new" line and added the old.
I hope someone can tell me how these two lines are supposed to be 
equivalent, or if there was a bug in the original (current) then how the 
"new" line was supposed to fix it.
Perhaps a much larger problem is that after this change, there was NO 
change in the regression I was reporting, even thought the logs clearly 
showed compile errors (the old log should still be ftp://rudbek.com/pub/boost )
My normal testing automatically kicked off 25 minutes ago, so it won't be 
there forever (the last run took FIVE(5) hours (the tests _had_ been 
running in about 2)).
I also changed two other files in iostream which suddenly got \r\r\n line 
endings (vc8.0 doesn't like those for some reason)
The fact that the change would likely have gone unnoticed if I hadn't been 
working on some updates for a client and _known_ that the program had 
compiled 26.5 hours ago, and failed 16 hours ago and could chase down who'd 
changed what is rather disturbing.
We _must_ make some changes in how the regression tests are run (or perhaps 
how the results are analyzed) if we ever hope to have reliable stuff going 
out the door.
I believe this throws into serious question whether it is reasonable to 
expect to do a release of a new version of boost in the immediate future 
(starting a freeze in 7 days).
Victor A. Wagner Jr.      http://rudbek.com
The five most dangerous words in the English language:
               "There oughta be a law"