From: michael toksvig (michaeltoksvig_at_[hidden])
Date: 2005-04-25 15:13:55
> Do you think the library should be accepted as a Boost library? Be sure to
> say this explicitly so that your other comments don't obscure your overall
> What is your evaluation of the design?
> What is your evaluation of the implementation?
> What is your evaluation of the documentation?
describe pitfalls, if any. actually, there is one pitfall:
BOOST_FOREACH(pair<Key, Value> &p, some_map)
does not work, since the preprocessor just can't get over that first comma
> What is your evaluation of the potential usefulness of the library?
it is hugely useful. i use it all the time
> Did you try to use the library? With what compiler? Did you have any
yes. with vc 7. no problems
> How much effort did you put into your evaluation? A glance? A quick
> reading? In-depth study?
> Are you knowledgeable about the problem domain?
"Gennadiy Rozental" <gennadiy.rozental_at_[hidden]> wrote in message
> The formal review of Eric Nibbler's FOREACH macro starts today, April 25,
> and will continue until Monday, May 1st. I will be serving as review
> BOOST_FOREACH is a macro that makes it simple to iterate over STL
> containers, ranges, arrays and null-terminated strings. Its performance
> approaches that of the hand-coded equivalent loop. BOOST_FOREACH uses
> Boost.Range can be extended to iterating user-defined collections by
> extending Boost.Range.
> The library is available at:
> Please note that the documentation is also available separately from the
> sources. It also can be viewed online at:
> The library is known to work (with different compliance levels) at least
> on the following compilers:
> * Visual C++ 7.1
> * Visual C++ Whidbey Beta
> * Visual C++ 7.0
> * Visual C++ 6.0
> * gcc 3.3.3
> * Intel for Windows 8.0
> * Intel for Windows 7.0
> * Comeau 4.3.3
> When submitting reviews, please state explicitly whether or not you
> that the library should be accepted into Boost.
> For more information on the Boost formal review process, please see
> Unsubscribe & other changes:
Boost list run by bdawes at acm.org, gregod at cs.rpi.edu, cpdaniel at pacbell.net, john at johnmaddock.co.uk