[boost] Re: Formal Review: Typeof

From: David Abrahams (dave_at_[hidden])
Date: 2005-05-20 15:55:23

"Arkadiy Vertleyb" <vertleyb_at_[hidden]> writes:

> "David Abrahams" <dave_at_[hidden]> wrote
>
>> Now I think I found the bug in my code and BOOST_TYPEOF is off the
>> hook.  Seems to be working fine so far!
>
> OK.  Just a couple of things I noticed:
>
> 1) copy.hpp doesn't have INCREMENT_REGISTRATION_GROUP.  This might result in
> a problem if you use emulation mode and this file is first to register a
> type or REGISTER_TYPE is on the same line number as in one of files included
> before;

Good catch.

> 2) the return type of the function call operator is:
>
> typename dispatch<copy_(typename add_const<Range1>::type&,Range2&)>::result
>
> ^^^^
> Is it intended?  I don't see a "result" typedef in the dispatch...

yeah, that was a major culprit; I caught it myself a little while
ago.  Unfortunately there are still problems with vc-8:

..\..\..\..\boost/sequence/detail/typeof_add.hpp(15) : error C2893: Failed to specialize function template 'char (&boost::type_of::size(const T &))[boost::mpl::size<encode_type<boost::type_of::vector0<>,T>::type>::value]'
        With the following template arguments:
        'T'
        ..\..\..\..\boost/sequence/detail/typeof_add.hpp(16) : see reference to class template instantiation 'boost::sequence::detail::typeof_add<T,U>' being compiled

See the updated archive.

-- 
Dave Abrahams
Boost Consulting
www.boost-consulting.com