Re: [boost][date_time] errors in time_facet.hpp (cvs HEAD)

From: Jeff Garland (jeff_at_[hidden])
Date: 2005-06-09 08:20:01

On Wed, 8 Jun 2005 21:45:55 +0200, Jan Hermelink wrote
> I think there are several errors in time_facet.hpp from cvs HEAD:
> 
> The lines using std::basic_string::find() evaluate the return code
> wrongly, e.g. line 227:
>       if (format.find(seconds_with_fractional_seconds_format)) {
> should be
>       if (format.find(seconds_with_fractional_seconds_format) !=
> string_type::npos) {
> I think.

Thanks for the report -- I've fixed this one in CVS.

> In addition I think "%%" should always evaluate to "%" and leave the
> following char unexpanded.
> Current e.g. "%%s" evaluates to "%59.000000", not to "%s". This is 
> the outcome of using boost::algorithm::replace_all().

Yep, I agree we should change this.  This one will have to wait till 1.34.
 
> Otherwise thank you for your great library!

Your welcome, thanks for the feedback!

Jeff