Re: [boost] MS compiler detection

From: David Abrahams (dave_at_[hidden])
Date: 2005-07-10 09:02:08

"John Maddock" <john_at_[hidden]> writes:

>> I ported large parts of Boost 1.32 to embedded Visual C++ 4 some time ago. 
>> One
>> of the major changes was because the included cross compilers reported
>> _MSC_VER somewhere in between 1200 and 1202. IOW, a plethora of cases that
>> checked ==1200 or >1200 failed to work for a few of them.
>
>> I already once submitted a patch, but it hasn't been incorporated yet, so 
>> here
>> is one against CVS from this afternoon. The changes I made were mostly
>> mechanical:
>
> My mistake, I think I promised to apply that, but never got around to it.
>
>>  MSC_VER <= 1200  ->  MSC_VER < 1300
>>  MSC_VER == 1200  ->  MSC_VER < 1300
>>  MSC_VER >= 1300  ->  MSC_VER > 1200
>
> That last one is wrong, 

They're all wrong (missing leading underscore on _MSC_VER) ;-)

> I assume you meant to type:
>
> MSC_VER >= 1200  ->  MSC_VER > 1200

No, that doesn't make sense either.  It changes semantics for versions
of _MSC_VER that were known to us before Ulrich pointed out the
existence of 1202.

-- 
Dave Abrahams
Boost Consulting
www.boost-consulting.com