Re: [boost] [program_options] portability patches

From: Vladimir Prus (ghost_at_[hidden])
Date: 2005-08-31 00:37:17

Fran?ois Dumont wrote:

> Here are several patches to improve portability for this library:
.....
> 
> - variables_map.cpp: A classic for loop internal variable problem, i is
> defined 2 times with a different type in 2 different for loop. 

And what msvc has to say about this (legal) code?

> I fix it 
> by using an iterator approach to enumerate the desc.options() container.
> 
> Thanks to those patches I build the lib with the msvc-stlport toolset
> with no problem.

Did you try to use the library, or run the internal tests. Your patches look
fine to me, but I'm still surprised that things work. In particular, does:
 
   variables_map vm;

   ...
   vm["foo"].as<int>()

work? IIRC, that never worked on msvc.

Thanks,
Volodya