[boost] [boost.python] Wrong version check? (was: Re: GCC >=4 "-fvisibility=hidden" patch)

From: Daryle Walker (darylew_at_[hidden])
Date: 2005-11-30 13:22:18

On 11/29/05 4:27 PM, "Jason Kankiewicz" <jkankiewicz_at_[hidden]> wrote:

> +# elif (defined(__GNUC__) && ((__GNUC__ >= 3 && __GNUC_MINOR__ >=5) ||
> __GNUC__ >= 4))

Shouldn't the check for GCC 3.x be:

    __GNUC__ == 3 && __GNUC_MINOR__ >= 5

instead of the currently over-broad version?  Otherwise version numbers like
4.6 or 5.9 would match on that phrase, which is wrong.  They should match on
the "__GNUC__ >= 4" phrase instead.  The problem phrase should only match on
3.5 through 3.9.x.

-- 
Daryle Walker
Mac, Internet, and Video Game Junkie
darylew AT hotmail DOT com