Re: [boost] [Review] Shmem Library

From: Ion Gaztañaga (igaztanaga_at_[hidden])
Date: 2006-02-09 16:21:22

Hi Pavel,

> I've played around with shmem library, and I was really impressed with
> it power, design and functionality. I definitely  think this library
> should be accepted into boost.

Thanks.

> Here, however, are the few glitches I've came by:
> 
> 1) in file containers_explained.html
> "boost:shmem" written several times instead of "boost::shmem"

Thanks for pointing it out.

> 2) in file named_shared_object.html
> Document states that basic_named_shared_object::open in  has 3
> parameters while open in reality it has only two (no size is passed to
> open)

Thanks!

> 3) Most of the pages missing includes files needed for particular
> class/feature. It would be nice, if, for example,
> shared_message_queue.html would mention
> <boost/shmem/ipc/shared_message_queue.hpp>

Ok, you are right. I will add the header which implements every class.

> And I would like to thank  Ion Gaztañaga for developing such a good
> library. Hope it will make its way to the proud family of boost
> libraries :)

I hope so!

Thanks for reviewing the library.

Ion