Re: [boost] [graph] PATCH for Re: A bug in smallest_last_vertex_ordering

From: Aaron Windsor (aaron.windsor_at_[hidden])
Date: 2006-03-20 19:29:40

On 3/20/06, Roman Dementiev <dementiev_at_[hidden]> wrote:
> Hi Aaron,

<snip>

> Aaron Windsor wrote:
> > Hi Roman,
> >
> > Thanks so much for the bug fix. I've just integrated it. Can I add the
> > test program you included in your original email to the BGL test suite?
>
> sure
>
> > It doesn't look like we have a test for smallest_last_ordering.hpp at
> > the moment.
>
> I have noticed that that the implementation starts removing vertices
> with degree 1, assuming that there are no isolated vertices. Therefore
> for graphs with degree-zero vertices the computed ordering will be
> wrong. Starting from minimum_degree = 0 solves the problem. See the
> attached patch.
>
>
> With best regards,
> Roman

Roman,

I just put the fix in for isolated vertices, but I'll have to wait
until after the
Boost 1.34 release branch to add the test. Thanks again for both.

Aaron