Re: [boost] Release procedures

From: Joe Gottman (jgottman_at_[hidden])
Date: 2006-06-26 21:20:09

"Fernando Cacciola" <fernando_cacciola_at_[hidden]> wrote in message 
news:e7plic$9b9$1_at_sea.gmane.org...
> Hi,
>
> I must be doing something wrong or I'm expecting something I shouldn't:
>
> (1) I updated from the trunk (HEAD)
> (2) Fixed a couple of things
> (3) Commited to the trunk
> (4) Updated from RC_1_34 (over the same working folder)
> (5) Merged "merged_from_RC_1_34" and "HEAD" into working folder.
>
> For step 5 I'm using ToroiseCVS 1.8.26 using the merge dialog as follow:
>
> Start: merged_from_RC_1_34
> End: HEAD
>

   The code seems to be in the CVS.  You've got one minor documentation 
typo.  Over the free function get_optional_value_or you have a comment that 
says "Returns a pointer to the value if this is initialized, otherwise, 
returns NULL."  This is incorrect.  The entire point of this function is to 
give defined behavior by returning a default value when the optional is 
uninitialized.

Joe Gottman