Re: [boost] Spurious warning in lexical_cast.hpp

From: Jürgen Hunold (hunold_at_[hidden])
Date: 2006-08-03 02:33:19

Hi Gennaro !

An'n Middeweken 02 August 2006, 17:36 hett Gennaro Prota schreven:
> On Wed, 2 Aug 2006 09:02:57 +0200, Jürgen Hunold <hunold_at_[hidden]>

> >The "fix" is wrong.
>
> I agree that it is not a "fix", FWIW. Just a change. But would you
> care explaining why it's "wrong"?

I wrote:
> It broke the "else if" statement at line 150 and my gcc
> (4.0.2-SuSE) complains about "boost/lexical_cast.hpp:150: warning:
> statement has no effect".

This is
---begin cut
                else
                    ((s::is_specialized) &&
                        stream.precision(s::digits10 + 1));
----end cut

and this should IMHO read:

                  else if (s::is_specialized)
                        stream.precision(s::digits10 + 1));

(see my patch...)
This is clearer and prevents a warning from gcc...
might be this will issue a warning from msvc-8.0...

This if obviously a case where "fixing" one warning introduces another.
I try to test those changes with at least one other compiler...

Yours,

Jürgen

-- 
* Dipl.-Math. Jürgen Hunold  ! Ingenieurgesellschaft für 
* voice: ++49 511 262926 57  ! Verkehrs- und Eisenbahnwesen mbH  
* fax  : ++49 511 262926 99  ! Lister Straße 15
* juergen.hunold_at_[hidden]   ! www.ivembh.de