Re: [boost] [regex] patch for config/platform/hpux.hpp

From: Boris Gubenko (Boris.Gubenko_at_[hidden])
Date: 2006-08-23 01:34:33

John,

I just realized, that unless BOOST_STRICT_CONFIG macro is defined
(which we don't), config/compiler/hp_acc.hpp defines BOOST_NO_SWPRINTF
macro. So, even if hpux.hpp would not define this macro, hp_acc.hpp
will.

I think, that for now, we should leave part of the hpux.hpp header
setting BOOST_NO_SWPRINTF and BOOST_NO_CWCTYPE macros alone because,
almost certainly, tuning configuration macros for HP-UX/aCC will
require a coordinated update of both hpux.hpp and hp_acc.hpp.

I think, that for now, we should change hpux.hpp to only define THREADS
macros for aCC (which is necessary for regex_regress_threaded and
static_mutex_test regex library tests to pass):

#if defined(__GNUC__)
...
#elif defined(__HP_aCC) && !defined(BOOST_DISABLE_THREADS)
#  define BOOST_HAS_THREADS
#  define BOOST_HAS_PTHREADS
#endif

Thanks for your help,
  Boris

----- Original Message ----- 
From: "Boris Gubenko" <Boris.Gubenko_at_[hidden]>
To: <boost_at_[hidden]>
Cc: "Boris Gubenko" <Boris.Gubenko_at_[hidden]>
Sent: Tuesday, August 22, 2006 2:37 PM
Subject: Re: [boost] [regex] patch for config/platform/hpux.hpp

> John Maddock wrote:
>>
>> Will do, but shouldn't
>>
> 
> Thank you!
> 
>>> < #if !(defined(__HP_aCC) && defined(_INCLUDE__STDC_A1_SOURCE))
>>> < #  define BOOST_NO_SWPRINTF
>>> < #  define BOOST_NO_CWCTYPE
>>> < #endif
>>
>> Be #if !(defined(__HP_aCC) && !defined(_INCLUDE__STDC_A1_SOURCE)) ?
>>
> 
> No, I don't think so. The original condition says: don't define
> BOOST_NO_SWPRINTF and BOOST_NO_CWCTYPE macros when compiling with aCC
> with _INCLUDE__STDC_A1_SOURCE macro defined. This macro exposes I18N
> features added in 11i. On appropriate platforms, aCC predefines
> this macro.
> 
> Thanks again,
>  Boris
> 
> ----- Original Message ----- 
> From: "John Maddock" <john_at_[hidden]>
> To: <boost_at_[hidden]>
> Cc: "Boris Gubenko" <Boris.Gubenko_at_[hidden]>
> Sent: Tuesday, August 22, 2006 12:41 PM
> Subject: Re: [boost] [regex] patch for config/platform/hpux.hpp
> 
> 
>> Boris Gubenko wrote:
>>>  The patch also enables native swprintf and cwctype when
>>>  _INCLUDE__STDC_A1_SOURCE macro is defined (on ia64, aCC
>>>  predefines this macro).
>>>
>>>  The hpux.hpp header is the same in RC_1_34 and HEAD and I'd
>>>  like the patch to be committed to both, if possible.
>>
>> Will do, but shouldn't
>>
>>> < #if !(defined(__HP_aCC) && defined(_INCLUDE__STDC_A1_SOURCE))
>>> < #  define BOOST_NO_SWPRINTF
>>> < #  define BOOST_NO_CWCTYPE
>>> < #endif
>>
>> Be #if !(defined(__HP_aCC) && !defined(_INCLUDE__STDC_A1_SOURCE)) ?
>>
>> Thanks, John.
>>
>> _______________________________________________
>> Unsubscribe & other changes: 
>> http://lists.boost.org/mailman/listinfo.cgi/boost
>>
>> 
>