[boost] [Boost-bugs] [ boost-Patches-1558580 ] Fix:"VAR on TARGET ?= values" unconditionally assigns values

From: SourceForge.net (noreply_at_[hidden])
Date: 2006-09-14 08:45:11

Patches item #1558580, was opened at 2006-09-14 12:44
Message generated for change (Settings changed) made by markovitch
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=307586&aid=1558580&group_id=7586

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Yakov Markovitch (markovitch)
Assigned to: Nobody/Anonymous (nobody)
>Summary: Fix:"VAR on TARGET ?= values" unconditionally assigns values

Initial Comment:
"VAR on TARGET ?= values" unconditionally assigns
values, i.e. works like "unconditional" assignment.
This bug is extremely insidious, since there is no hint
of wrong behaviour at all (it costed me a full day of
futile debugging of my jam script before it dawned upon
me that it is something wrong with assignment).
Interesting, that documentation actually doesn't
mention that "default assignment" is available on
target, i.e. this is a "feature", but this requires
_very_ attentive reading of documentation and is quite
inconsistent. And even so it is a bug: there should be
at least a syntax error!

There are two ways to fix this bug:

1. Bring code into sync with doc, i.e. patch the syntax
so that "VAR on TARGET ?= values" would be a syntax
error. IMO strange, inconsistent and inconvinient.

2. Patch addsettings so that it handled default
assignment correctly.

The proposed patch implements the latter approach. 
The addsettings() function now accepts "setflag"
(VAR_SET, VAR_ADD, VAR_DEFAULT) the same way as
var_set() does, instead of logical "append" parameter.
All addsettings() calls patched accordingly. 
Besides, it factors out the logic of converting
ASSIGN_XXX compilation flag into corresponding VAR_XXX
variable set flag into a separate static function.

The patch is against CVS HEAD.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=307586&aid=1558580&group_id=7586

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Boost-bugs mailing list
Boost-bugs_at_[hidden]
https://lists.sourceforge.net/lists/listinfo/boost-bugs