Re: [boost] [serialization][test] Last few serializationregressionswith VC6

From: John Maddock (john_at_[hidden])
Date: 2006-10-30 05:04:19

Gennadiy Rozental wrote:
>> 2) Is there a particular reason why the problem template
>> (equal_impl_frwd in
>> test_tools.hpp) is marked as exported, when it contains only inline
>> functions?  I realise it shouldn't make any difference either which
>> way, and
>> if it's used by classes that do need to be exported then it
>> suppresses a whole lot of warnings so I guess that's the reason ? :-)
>
> You probably right, but I would prefer not to touch this, since I
> don't have resources at the moment to test it.

Gennadiy, I've now tested this change with VC 6, 7, 7.1, 8 and Intel 9.1 and 
there are no regressions in Boost.Test.  I've also confirmed that it fixes 
the serialisation failures.

The change I made was simply:

Index: boost/test/test_tools.hpp
===================================================================
RCS file: /cvsroot/boost/boost/boost/test/test_tools.hpp,v
retrieving revision 1.60.2.1
diff -r1.60.2.1 test_tools.hpp
485c485
< struct BOOST_TEST_DECL equal_impl_frwd {
---
> struct /*BOOST_TEST_DECL*/ equal_impl_frwd {
Is this acceptable to commit?
Thanks, John.