Re: [boost] [test] regression between 1.32.0 and 1.33.1 in "included"test framework

From: Michael van der Westhuizen (r1mikey_at_[hidden])
Date: 2006-11-14 16:05:40

Hi Gennadiy,

On 11/8/06, Gennadiy Rozental <gennadiy.rozental_at_[hidden]> wrote:
>
> "Michael van der Westhuizen" <r1mikey_at_[hidden]> wrote in message
> news:d21d65950610270423n5bf2f72ak9cfdacd30408f13b_at_mail.gmail.com...
> > Hi All,
> >

[snip a whole lot of broken code]

> >
> > class DummyTest
> >  : public boost::unit_test_framework::test_suite
>
> You are *NOT* supposed to be doing this.
>
> > {
> > public:
> >    DummyTest() :
> >      boost::unit_test_framework::test_suite( "DummyTest" ) {}
> >    void testDummy() { BOOST_CHECK( true ); }
> > };
>
> Correct definition would look like:
>
> class DummyTest {
> public:
>    void testDummy() { BOOST_CHECK( true ); }
> };
>

Oh dear - that was very wrong, wasn't it!

Thanks, I've corrected this in our tests, and can confirm that this
was all caused by our code, not the test framework.

>
> I will make sure this code wont compile.
>
> Gennadiy

Please do that - it'll help protect people like me from ourselves :-)

Michael