Re: [boost] UTF8 library - second call for informal review

From: Anthony Williams (anthony_w.geo_at_[hidden])
Date: 2006-12-06 06:22:41

Nemanja Trifunovic <nemanja_trifunovic_at_[hidden]> writes:

> This is the second call for the informal review of the UTF8 library. It is
> based on verson 1.02 of UTF8-CPP: http://utfcpp.sourceforge.net/ and you can
> find it at
> http://boost-consulting.com/vault/index.php?PHPSESSID=8j6irqkpv3reg5s1gv0lge6um5&direction=0&order=&directory=Strings%20-%20Text%20Processing

First, a typo: there is a missing 'n' in octet_differece_type defined in
validate_next, on line 122.

Secondly, a real issue: validate_next currently requires bidirectional
iterators, in order to backtrack on error. Forward iterators are sufficient
for this --- just store a copy of the original, and copy it back if there's an
error. This would increase the number of use cases of the library.

I agree that a converting iterator would be beneficial, as would a codecvt
facet, but this is a good start.

Anthony
-- 
Anthony Williams
Software Developer
Just Software Solutions Ltd
http://www.justsoftwaresolutions.co.uk