Re: [boost] Accumulators ublas::vector

From: Eric Niebler (eric_at_[hidden])
Date: 2006-12-18 11:54:54

Niitsuma Hirotaka wrote:
> I enabled ublas::vector as vector data in acc.
> Plz try attached code

A couple of things:

1)
You've put the typeof registration for ublas::vector into the typeof 
library. It doesn't belong there. It belongs in the ublas library. I 
think you should contact the owner of ublas for that.

2)
You defined a += operator for adding a ublas vector to another ublas 
vector. Does ublas vector already define this operator? At least, that's 
what the docs say.

3)
Why the "#if 0" code in covariance.hpp? Can you remove the dead code?

Thanks for your work on this!

-- 
Eric Niebler
Boost Consulting
www.boost-consulting.com