Re: [boost] [xpressive] HEAD doc issue

From: Vladimir Prus (ghost_at_[hidden])
Date: 2007-01-10 02:37:24

Eric Niebler wrote:

> Vladimir Prus wrote:
>> Eric Niebler wrote:
>>> Vladimir Prus wrote:
>>>> I would expect the following patch to better reflect your intention.
>>>> After all, the output of quickbook actually does not depend on autodoc
>>>> at all, it's the output of boostbook that depends on it. Ok to commit?
>>>
>>> What patch?
>> 
>> Doh! Attached now.
>> 
>> 
>> ------------------------------------------------------------------------
>> 
>> ? autodoc.boostbook
>> ? html
>> ? xml
>> ? xpressive.diff
>> Index: Jamfile.v2
>> ===================================================================
>> RCS file: /cvsroot/boost/boost/libs/xpressive/doc/Jamfile.v2,v
>> retrieving revision 1.10
>> diff -u -p -r1.10 Jamfile.v2
>> --- Jamfile.v2       22 Oct 2006 03:28:00 -0000      1.10
>> +++ Jamfile.v2       9 Jan 2007 20:01:43 -0000
>> @@ -25,8 +25,6 @@ doxygen autodoc
>>  xml xpressive
>>      :
>>          xpressive.qbk
>> -    :
>> -        <dependency>autodoc
>>      ;
>>  
>>  boostbook standalone
>> @@ -36,4 +34,5 @@ boostbook standalone
>>          <xsl:param>toc.max.depth=3
>>          <xsl:param>toc.section.depth=3
>>          <xsl:param>chunk.section.depth=3
>> +    <dependency>autodoc
>>      ;
> 
> 
> Wouldn't that only create the necessary dependency when the docs are
> built "standalone"? 

Looking at doc/Jamfile.v2, I see:

    <dependency>../libs/xpressive/doc//autodoc.xml

so I suppose everything is in shape.

> This doesn't seem right to me. I think I said what I 
> meant to: that the xml rule invocation depends on the doxygen one.

How can it depend if the qbk -> xml process does not use the autodoc result
in any way.

> Could you also explain how simply making one rule invocation depend on
> another breaks the build? 

Because quickbook.jam has a bug? Which bug certainly can be fixed, but
using <dependency> in Jamfile like this does not seem right to me either.

> Why should that be? And what's up with that 
> error message:
> 
> error: Unable to find file or target named
> error:     'object(file-target)@427'
> error: referred from project at
> error:     '/home/ghost/Work/Boost/boost/tools/quickbook'
> 
> That's awful. How's anyone supposed to make any sense of that?

Just like how anyone is supposed to make any sense of failed assert
in a C++ program? Not all errors can be made cristal clear, 
quickbook.jam in particular is deep wizardy. 

- Volodya