Re: [boost] [Bind] min_arity: the patch

From: Joel de Guzman (joel_at_[hidden])
Date: 2007-01-21 20:37:14

Sohail Somani wrote:
> Hi,
> 
> (CC'ing Peter and Joel)
> 
> I've developed a patch after a somewhat short discussion on the users
> list for adding the ability to determine the number of arguments
> required at minimum for a bind expression. It is developed as a
> non-intrusive patch to bind and fusion. Basic usage is as follows:

I'll comment on the fusion side of things. For now, since I did
just a cursory look, my comments will be superficial. 1) Please
follow fusion coding conventions (e.g. your copyright at the top,
spaces instead of tabs, indent styles, etc.) 2) I'm not so sure
about using python to generate the specializations. I'd rather
see Boost PP code; some examples can be found in the fusion code
(e.g. vector1..vectorN). I'd like to avoid the use of an external
tool as much as possible.

Overall, it looks good! Nice work!

Regards,
-- 
Joel de Guzman
http://www.boost-consulting.com
http://spirit.sf.net