Re: [boost] [FSM] Review library version update

From: Fabien Niñoles (fabien.ninoles_at_[hidden])
Date: 2007-02-05 16:31:47

2007/2/5, Andrey Semashev <andysem_at_[hidden]>:
>
> I guess there should have been only "scoped_lock
> second_lock(m_mutex2)" and no "scoped_lock first_lock(m_mutex1)".
> Still, m_mutex2 has to be initialized somewhere and I see no other way
> for it than to be global, in namespace scope. But once again, I'm not
> sure even this is actually safe since it's dynamic initialization
> which apparently may be done concurrently.

You're perfectly right on this issue: only the second_lock is necessary, and
pInstance must also be volatile (I never write such code myself, I always
used  Loki implementation when I need a singleton).  As for instanciation,
the standard ensure that a local static variable will only be initialized
once, before entrance to the block scope.  How this is handled in
multi-thread program?  I guess it's depend on your threaded platform.  As
for where the mutexes is defined... Well, that's also depends on the class
policy (and what's the mutex implementation permits).

Unless you can ensure that the private variable will not be necessary
anytime before it's initialization (for example, by a static object inside
another module), I'm still thinking that the local static variable is safer
than a class static variable.

Fabien