Re: [boost] [Fwd: [1.34.0 beta] GCC toolset version/flavor detection patch. (attn Thomas Witt)]

From: Vladimir Prus (ghost_at_[hidden])
Date: 2007-05-03 01:13:26

Thomas Witt wrote:

> 
> Volodya,
> 
> can you have a look at this. I am inclined to put it in RC_1_34_0 if you
> think it's OK.

......

> Index: tools/build/v2/tools/gcc.jam
> ===================================================================
> RCS file: /cvsroot/boost/boost/tools/build/v2/tools/gcc.jam,v
> retrieving revision 1.89
> diff -u -r1.89 gcc.jam
> --- tools/build/v2/tools/gcc.jam      3 Apr 2007 17:10:53 -0000       1.89
> +++ tools/build/v2/tools/gcc.jam      3 May 2007 02:48:10 -0000
> @@ -81,10 +81,11 @@
>            # The 'command' variable can have multiple elements. When
>            # calling the SHELL builtin we need a single string.
>            local command-string = $(command:J=" ") ;
> -        local command-info = [ MATCH "^[^ ]+[ ]+[^ ]+[ ]+([^
> ]+)[^(]*[(]?([^)]*)"
> -            : [ SHELL "$(command-string) --version" ] ] ;
> -        version ?= $(command-info[1]) ;
> -        switch $(command-info[2]:L)
> +        local machine = [ MATCH "^([^ ]+)"
> +            : [ SHELL "$(command-string) -dumpmachine" ] ] ;
> +        version ?= [ MATCH "^([0-9.]+)"
> +            : [ SHELL "$(command-string) -dumpversion" ] ] ;
> +        switch $(machine:L)
>            {
>                case *mingw* : flavor ?= mingw ;
>            }

This change appears to be safe to me.

- Volodya