Re: [boost] [algorithm][string] Edit distance algorithm

From: JD (jean.daniel.michaud_at_[hidden])
Date: 2007-05-16 07:42:23

> Function signature looks fine now, but if you want to be
> range-compliant, there are few issues in your implementation.
> 
> 1.
> instead of
> 	std::size_t Arg1Size = Arg1End - Arg1It;
> use
> 	boost::range_size<Arg1>::type Arg1Size = size(Arg1);
> 

Done.

> 2.
> I don't like the usage of plane C-Arrays. Even if you wanna use them,
> you should wrap the pointers to something like boost::scoped_array.
> Currently your code does not provide even the basic exeption quarantie
> (you will unconditionaly leak memory if an exception is thrown) and
> that's bad for this kind of algorithm.
> 

Ok, I just move to std::vector.
New version uploaded: http://minilien.com/?rrDciLH4g9

Regards,

JD