Re: [boost] [variant]bug: max used instead of lcm

From: Eric Friedman (ebf_at_[hidden])
Date: 2007-05-24 14:52:21

Larry,

Larry Evans wrote:
> The make_storage template at line 215 of:
> 
> http://boost.cvs.sourceforge.net/boost/boost/boost/variant/variant.hpp?revision=1.97&view=markup
> 
> uses max over the alignment_of's for the types in the variant
> (See line2 233-235) to calculate the variant's alignment.
> However, to handle the extended alignments described on page 3 of:
> 
>   http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2007/n2165.pdf
> 
> the boost::math::static_lcm template should be used instead of max.

Excellent catch. I've created http://svn.boost.org/trac/boost/ticket/993 
for this issue.

The question I have now is the urgency of the fix. In particular, this 
issue has been in the code since the beginning but has not been 
reported, suggesting perhaps it has not caused problems in practice. Do 
you have any thoughts?

Thanks,

Eric