Re: [boost] [guid] - review results? - inline missing

From: Andy (atompkins_at_[hidden])
Date: 2007-05-31 12:33:13

<Oliver.Kowalke_at_[hidden]> wrote in
news:D0E7D90F1C8088459FBD399DE6D966FB606B6E_at_[hidden]: 

> Hello Andy, 
> 
>> > some function definitions are missing the inline keyword 
>> (sha1.hpp and 
>> > uuid.hpp).
>> 
>> I will be happy to make these changes.  Which functions?
> 
> Each function definition in both files - you have separated the
> function declaration from definition and you put the definition also
> in the header. Without inlineing in the definition you get for
> instance "multiple definition of `boost::uuid::create()'" errors.
> 
> uuid.hpp
> 
> uuid uuid::create() : line 364
> uuid uuid::create_random_based(Engine& engine) : line 374
> std::basic_ostream<ch, char_traits>& operator<<(std::basic_ostream<ch,
> char_traits> &os, uuid const& u) : line 405
> std::basic_istream<ch, char_traits>& operator>>(std::basic_istream<ch,
> char_traits> &is, uuid &u) : line 438
> 
> sha1.hpp
> 
> unsigned int left_rotate(unsigned int x, size_t n) : line 26
> void sha1::reset() : line 63
> sha1::sha1() : line 58
> void sha1::process_block() : line 100
> void sha1::process_byte(unsigned char byte) : line 75
> void sha1::process_block(void const* bytes_begin, void const*
> bytes_end) 
>: line 85
> void sha1::process_bytes(void const* buffer, std::size_t byte_count) :
> line 94
> void sha1::get_digest(digest_type digest) : line 152
> 
> regards, Oliver
> _______________________________________________
> Unsubscribe & other changes:
> http://lists.boost.org/mailman/listinfo.cgi/boost 
> 

Thanks!
I added 'inline' to the non-template functions.  I don't get the error
for the templated functions.  I can still add 'inline' to those if I
should/need to.  I am using visual studio .NET, maybe that makes a
difference? 

I uploaded uuid_v9.zip to the boost vault.  Will you give it a try for
me? 

Thanks in advance,
  Andy.