Re: [boost] [hash] GCC warnings with -Wsign-promo (was: multi-index warnings)

From: Joaquín Mª López Muñoz (joaquin_at_[hidden])
Date: 2007-07-17 10:57:54

Marius Lazer ha escrito:

> Joaquín,
>
> Yes, I forgot the compiler flag when I compiled standalone boost/functional/hash/hash.hpp. Sorry for the confusion.
>
> I can confirm that your analysis is both complete and accurate. We use the highest level of warnings (in the spirit of terseness I omitted all the others like -Wall, etc.) and -Wsign-promo actually found problems so I'd be inclined to keep it.
>
> If someone in the Boost team can guarantee that these warnings are 100% benign (i.e. noise) I can live with them (or just turn -Wsign-promo off for the offending modules), otherwise I'd like to have them fixed.

I think they're harmless, but the author of Boost.Hash has the final say.
I've created a ticket for the issue at:

http://svn.boost.org/trac/boost/ticket/1095

Best regards,

Joaquín M López Muñoz
Telefónica, Investigación y Desarrollo