Re: [boost] [time_series] Review

From: Michael Fawcett (michael.fawcett_at_[hidden])
Date: 2007-08-08 15:06:28

On 8/8/07, Eric Niebler <eric_at_[hidden]> wrote:
>
> Michael Fawcett wrote:
> > On 8/8/07, Eric Niebler <eric_at_[hidden]> wrote:
> >> Steven Watanabe wrote:
> >>> time_series_facade.hpp line 280
> >>>             this->sout_
> >>>                 << " value = " << value << ", "
> >>>                 << " offset = " << start << ", "
> >>>                 << " end offset = " << stop << '\n';
> >>> value shouldn't have a space before it should it?
> >>
> >> Probably not.
> >
> > Nit-picky, but "offset" and "end offset" probably shouldn't have
> > spaces before them either since the space is with the comma in the
> > previous line, right?
>
>
> You're right, of course, but this is really just a debug aid. A general
> ostream inserter for time series should be more configurable than this.
> I'm not sure what it should look like exactly, and I'm also not sure if
> this is a problem the time series library really needs to be solving.

Very reminiscent of the Quan/Units reviews.  IMHO, you did the right
thing going the Units route by not trying to include any fancy IO
mechanisms.

--Michael Fawcett