|
Boost : |
From: Joaquín Mª López Muñoz (joaquin_at_[hidden])
Date: 2007-10-09 05:09:06
Alexander Nasonov ha escrito:
> JoaquÃn Mª López Muñoz <joaquin <at> tid.es> writes:
>
> > The decision is yours to make, of course, but disabling the static assertions
> > seems to suffice --the compile-time calculations are indeed OK and hold
> > correct values once lcast_precision is instantiated.
>
> My decision is based on the fact that your change ommits some checks while
> my suggestion just moves them to runtime. Though, these checks can be
> violated only if a user sets digits or digits10 to extrememly high value.
Yep, moving to runtime is defintely safer when viewed that way. Thank you
for taking care of this! Contact me if you need some local testing before
commiting the changes.
Joaquín M López Muñoz
Telefónica, Investigación y Desarrollo
Boost list run by bdawes at acm.org, gregod at cs.rpi.edu, cpdaniel at pacbell.net, john at johnmaddock.co.uk