Re: [boost] [log] Boost Logging Lib v2, 0.9.3

From: John Torjo (john.groups_at_[hidden])
Date: 2007-10-31 05:15:28

Jens Seidel wrote:
> On Tue, Oct 30, 2007 at 07:18:57PM +0200, John Torjo wrote:
>   
>> Jens Seidel wrote:
>>     
>>> I attached another patch which allows now to properly compile at least
>>> each header file (independently) of Boost.Log.
>>>       
>> ===================================================================
>> --- boost/logging/format/formatter/defaults.hpp	(Revision 40606)
>> +++ boost/logging/format/formatter/defaults.hpp	(Arbeitskopie)
>> @@ -24,6 +24,7 @@
>>  #include <boost/logging/detail/fwd.hpp>
>>  #include <boost/logging/detail/manipulator.hpp>
>>  #include <boost/logging/format/formatter/time.hpp>
>> +#include <sstream> // std::basic_ostringstream
>>  #include <stdio.h>
>>
>>
>> Why use <sstream> ? I tried to minimize dependencies. In defaults.hpp there's no need for basic_ostringstream.
>>     
>
> You're wrong, it is required! I tested with both a recent 4.x gcc
> version (don't remember what version I used in the last test) and
> 3.4. (Didn't you see my comment std::basic_ostringstream? Search for
> this and you will find at least one match in the file!)
>
>   
My mistake  ;) I thought it's boost/logging/defaults.hpp . Fixed now.
Fixed the rest also. Committed to SVN.

Best,
John

-- 
http://John.Torjo.com -- C++ expert
... call me only if you want things done right